Fix grammar in docs by adding omitted word#4121
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 30, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
- Coverage 59.16% 59.15% -0.01%
==========================================
Files 287 285 -2
Lines 24716 24713 -3
==========================================
- Hits 14623 14619 -4
Misses 9209 9209
- Partials 884 885 +1 |
Member
|
CI failures are unrelated; Looks like some fixtures need updating; === FAIL: e2e/container TestCreateWithContentTrust (0.24s)
create_test.go:18: assertion failed:
Command: docker image push registry:5000/trust-create:latest
ExitCode: 1
Error: exit status 1
Stdout: The push refers to repository [registry:5000/trust-create]
5bef08742407: Preparing
5bef08742407: Mounted from alpine
latest: digest: sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d size: 528
Signing and pushing trust metadata
Stderr: Error: error contacting notary server: x509: certificate has expired or is not yet valid: current time 2023-03-26T12:52:08Z is after 2023-03-25T14:47:57Z
Failures:
ExitCode was 1 expected 0
Expected no error |
Edited second paragraph under ### Daemon configuration file to change "regardless their value" to "regardless of their value" Signed-off-by: Jake Stokes <contactjake@developerjake.com>
thaJeztah
force-pushed
the
fix-docs-grammar
branch
from
13864a2 to
9335690
Compare
Member
|
did a quick rebase, as CI should be fixed now 👍 |
Member
|
All green now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Edited second paragraph under ### Daemon configuration file to change "regardless their value" to "regardless of their value"
- How I did it
Edited second paragraph under ### Daemon configuration file to change "regardless their value" to "regardless of their value"
- How to verify it
Look
- Description for the changelog
Edited second paragraph under ### Daemon configuration file to change "regardless their value" to "regardless of their value"
- A picture of a cute animal (not mandatory but encouraged)
